Skip to content

Add animal consumption of litter#566

Merged
jacobcook1995 merged 11 commits intodevelopfrom
545-add-litter-consumption
Sep 25, 2024
Merged

Add animal consumption of litter#566
jacobcook1995 merged 11 commits intodevelopfrom
545-add-litter-consumption

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR adds animal consumption of litter to the Virtual Ecosystem. To resolve the timing issue that arises in coupling the two models, animals consume litter first and then the remainder decays (this may have to be worked on in future).

Fixes #545

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Sep 23, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (c81b21c) to head (056b14c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #566      +/-   ##
===========================================
+ Coverage    95.01%   95.04%   +0.03%     
===========================================
  Files           74       74              
  Lines         4235     4262      +27     
===========================================
+ Hits          4024     4051      +27     
  Misses         211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@TaranRallings TaranRallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobcook1995 jacobcook1995 merged commit 25831d9 into develop Sep 25, 2024
@jacobcook1995 jacobcook1995 deleted the 545-add-litter-consumption branch September 25, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add litter consumption

3 participants